Skip to content

scala cask fix for missing annotations on simple routes#18371

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
aaronp:cask-fix
Apr 12, 2024
Merged

scala cask fix for missing annotations on simple routes#18371
wing328 merged 1 commit intoOpenAPITools:masterfrom
aaronp:cask-fix

Conversation

@aaronp
Copy link
Copy Markdown
Contributor

@aaronp aaronp commented Apr 12, 2024

This small change fixes an issue with the recently added scala-cask generator for cases where there are a single route.

In this case, the route annotation would be elided, e.g.:

        ("")
        def createContract(request: cask.Request) = ...

PR checklist

  • [ x] Read the contribution guidelines.
  • [ x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x ] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [ x] File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [ x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 merged commit 85c81e8 into OpenAPITools:master Apr 12, 2024
@wing328 wing328 added this to the 7.5.0 milestone Apr 12, 2024
@aaronp
Copy link
Copy Markdown
Contributor Author

aaronp commented Apr 12, 2024

Sorry @wing328 - just when you thought you were rid of me ;-)

@aaronp aaronp deleted the cask-fix branch April 24, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants