Skip to content

fixes #18489: provide support of array attributes in multipart/form-data request for angular typescript client#18490

Merged
macjohnny merged 1 commit intoOpenAPITools:masterfrom
jeandonaldroselin:patch-1
Jun 5, 2024
Merged

fixes #18489: provide support of array attributes in multipart/form-data request for angular typescript client#18490
macjohnny merged 1 commit intoOpenAPITools:masterfrom
jeandonaldroselin:patch-1

Conversation

@jeandonaldroselin
Copy link
Copy Markdown
Contributor

@jeandonaldroselin jeandonaldroselin commented Apr 24, 2024

If first declared the issue there => #18489

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Please review my PR :
@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka

Copy link
Copy Markdown
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think this change can be done without introducing an option. The square brackets are a convention for languages like PHP, but not a standard, see eg https://stackoverflow.com/a/29371999

@jeandonaldroselin jeandonaldroselin force-pushed the patch-1 branch 4 times, most recently from 3f7feaa to e70d318 Compare May 28, 2024 16:57
@jeandonaldroselin
Copy link
Copy Markdown
Contributor Author

jeandonaldroselin commented May 28, 2024

Hello @macjohnny,

Thank you for your quick reply,

I added an option named useSquareBracketsInArrayNames.
Setting this property to true will add brackets to array attribute names.

@jeandonaldroselin jeandonaldroselin force-pushed the patch-1 branch 3 times, most recently from c943917 to f07eb43 Compare May 28, 2024 22:01
@macjohnny
Copy link
Copy Markdown
Member

please re-generate the docs

@jeandonaldroselin jeandonaldroselin force-pushed the patch-1 branch 2 times, most recently from 7483386 to 7cd17af Compare May 29, 2024 17:52
…ipart/form-data request for angular typescript client
@macjohnny macjohnny merged commit 17a08d2 into OpenAPITools:master Jun 5, 2024
@jeandonaldroselin
Copy link
Copy Markdown
Contributor Author

jeandonaldroselin commented Jun 5, 2024

Hello @macjohnny,

Thank you for the time you took to review 🙌🏾
I hope this fix will we be usefull for a maximum of teams.
See you ++

welshm pushed a commit to welshm/openapi-generator that referenced this pull request Jun 5, 2024
…ipart/form-data request for angular typescript client (OpenAPITools#18490)
@wing328 wing328 added this to the 7.7.0 milestone Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants