fixes #18489: provide support of array attributes in multipart/form-data request for angular typescript client#18490
Merged
macjohnny merged 1 commit intoOpenAPITools:masterfrom Jun 5, 2024
Conversation
macjohnny
requested changes
Apr 25, 2024
Member
macjohnny
left a comment
There was a problem hiding this comment.
I dont think this change can be done without introducing an option. The square brackets are a convention for languages like PHP, but not a standard, see eg https://stackoverflow.com/a/29371999
3f7feaa to
e70d318
Compare
Contributor
Author
|
Hello @macjohnny, Thank you for your quick reply, I added an option named useSquareBracketsInArrayNames. |
c943917 to
f07eb43
Compare
Member
|
please re-generate the docs |
macjohnny
reviewed
May 29, 2024
7483386 to
7cd17af
Compare
macjohnny
approved these changes
May 30, 2024
7cd17af to
98ff6d6
Compare
…ipart/form-data request for angular typescript client
98ff6d6 to
dcc6410
Compare
Contributor
Author
|
Hello @macjohnny, Thank you for the time you took to review 🙌🏾 |
welshm
pushed a commit
to welshm/openapi-generator
that referenced
this pull request
Jun 5, 2024
…ipart/form-data request for angular typescript client (OpenAPITools#18490)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If first declared the issue there => #18489
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)Please review my PR :
@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka