[BUG] [Python] Fix autoset constants Python code for default query string value#19138
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Aug 4, 2024
Merged
Conversation
Member
|
thanks for the pr CC |
Member
|
thanks for the PR. let's give it a try |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#16761 introduced Python code to set default header or query string value when OpenAPI parameter is required and has one enum value (have to use
--additional-properties autosetConstants=trueto activate functionality).The Python mustache template tries to add parameter to
_query_paramsdict, butquery_paramsis a list:https://github.com/prashant-pant/openapi-generator/blob/21ee1101f5fb310904ae904018cee93d249b796d/modules/openapi-generator/src/main/resources/python/api.mustache#L196-L228
This PR updates mustache template to append query string tuple to
_query_stringlist.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)