Skip to content

[html] Use ModelUtils to avoid NullPointerException#1948

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
jmini:issue1623
Jan 20, 2019
Merged

[html] Use ModelUtils to avoid NullPointerException#1948
wing328 merged 1 commit intoOpenAPITools:masterfrom
jmini:issue1623

Conversation

@jmini
Copy link
Copy Markdown
Member

@jmini jmini commented Jan 20, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @wing328

Description of the PR

Fixes #1623

@auto-labeler
Copy link
Copy Markdown

auto-labeler Bot commented Jan 20, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

Copy link
Copy Markdown
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix 👍

@wing328 wing328 added this to the 4.0.0 milestone Jan 20, 2019
@wing328
Copy link
Copy Markdown
Member

wing328 commented Jan 20, 2019

The CircleCI failure is not related to this PR.

@wing328 wing328 merged commit 0682462 into OpenAPITools:master Jan 20, 2019
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants