Skip to content

[csharp] Output DateOnly paramater in the correct default format (#19728)#19729

Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom
alec-petersen:dateonly-output-in-incorrect-format
Oct 7, 2024
Merged

[csharp] Output DateOnly paramater in the correct default format (#19728)#19729
wing328 merged 3 commits intoOpenAPITools:masterfrom
alec-petersen:dateonly-output-in-incorrect-format

Conversation

@alec-petersen
Copy link
Copy Markdown
Contributor

@alec-petersen alec-petersen commented Sep 30, 2024

The DateOnly object was previously unhandled when being converted to a string in ParameterToString. This PR adds handling for DateOnly in the same way the other date objects are handled and outputs it in the correct default format. This conditional is only added if we are net60 or later.

For issue #19728

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@alec-petersen alec-petersen changed the title [csharp] Output DateOnly in the correct default format (#19728) [csharp] Output DateOnly paramater in the correct default format (#19728) Sep 30, 2024
@alec-petersen alec-petersen force-pushed the dateonly-output-in-incorrect-format branch 2 times, most recently from 5b210bb to 92a5118 Compare October 1, 2024 11:23
@alec-petersen
Copy link
Copy Markdown
Contributor Author

@devhl-labs Think I'm supposed to tag you on this one.

@devhl-labs
Copy link
Copy Markdown
Contributor

I am not an approver but this is fine.

@alec-petersen
Copy link
Copy Markdown
Contributor Author

@devhl-labs My bad, and thanks! @mandrean @shibayan @Blackclaws @lucamazzanti @iBicha , would it be possible to get a review on this?

@wing328 wing328 merged commit c7d9857 into OpenAPITools:master Oct 7, 2024
@wing328 wing328 added this to the 7.9.0 milestone Oct 7, 2024
@alec-petersen alec-petersen deleted the dateonly-output-in-incorrect-format branch October 7, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants