Skip to content

Added default headers to ServerError<T> for Kotlin OkHTTP generator#20161

Merged
4brunu merged 1 commit intoOpenAPITools:masterfrom
ranger-ross:kotlin-api-response-types-headers
Nov 22, 2024
Merged

Added default headers to ServerError<T> for Kotlin OkHTTP generator#20161
4brunu merged 1 commit intoOpenAPITools:masterfrom
ranger-ross:kotlin-api-response-types-headers

Conversation

@ranger-ross
Copy link
Copy Markdown
Contributor

See: #20160

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@4brunu
Copy link
Copy Markdown
Contributor

4brunu commented Nov 22, 2024

hi @ranger-ross thanks for the PR, looks good to me 👍

@4brunu 4brunu merged commit 23aa2e2 into OpenAPITools:master Nov 22, 2024
@wing328 wing328 added this to the 7.11.0 milestone Dec 17, 2024
@ranger-ross ranger-ross deleted the kotlin-api-response-types-headers branch April 26, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants