Skip to content

Conversation

@andeb
Copy link
Contributor

@andeb andeb commented Jan 29, 2026

Small clean-up that removes unnecessary cast. Both HttpServerErrorException and HttpClientErrorException extend the base class HttpStatusCodeException and have access to the getStatusCode() method.

PR checklist

  • [ X ] Read the contribution guidelines.
  • [ X ] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [ X ] Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [ X ] File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [ X ] If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • [ X ] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @cachescrubber @welshm @MelleD @atextor @manedev79 @javisst @borsch @banlevente @Zomzog @martin-mfg @wing328


Summary by cubic

Removed an unnecessary cast in the RestTemplate ApiClient retry logic. The code now calls getStatusCode() on the shared base type (HttpStatusCodeException) to detect 429 Too Many Requests, keeping behavior the same while simplifying the condition.

Written for commit acc7a69. Summary will update on new commits.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

@wing328
Copy link
Member

wing328 commented Jan 30, 2026

looks good 👍

let's give it a try

thanks for the contribution

@wing328 wing328 merged commit 063a780 into OpenAPITools:master Jan 30, 2026
105 checks passed
@wing328 wing328 added Client: Java Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Jan 30, 2026
@wing328 wing328 added this to the 7.20.0 milestone Jan 30, 2026
@wing328 wing328 changed the title Removed unnecessary cast to HttpClientErrorException as both classes in the catch extend HttpStatusCodeException [resttemplate] Removed unnecessary cast to HttpClientErrorException as both classes in the catch extend HttpStatusCodeException Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client: Java Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants