Skip to content

[csharp] Fix/override central package versions for csharp test projects#23092

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
wturk:fix/overide-central-package-versions-csharp
Mar 2, 2026
Merged

[csharp] Fix/override central package versions for csharp test projects#23092
wing328 merged 2 commits intoOpenAPITools:masterfrom
wturk:fix/overide-central-package-versions-csharp

Conversation

@wturk
Copy link
Contributor

@wturk wturk commented Mar 2, 2026

The generated test .csproj was missing <ManagePackageVersionsCentrally>false</ManagePackageVersionsCentrally> in its <PropertyGroup>, unlike the main client .csproj which already includes it. This caused build failures in repositories that enforce Central Package Management (CPM).
This PR updates the test project template to match the client project template by adding the missing property.

Fixes #23090

@mandrean @shibayan @Blackclaws @iBicha

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Adds ManagePackageVersionsCentrally=false to generated C# test project templates to override Central Package Management and prevent build failures in CPM-enforced repos. Regenerates C# samples to include this property. Fixes #23090.

  • Bug Fixes
    • Add ManagePackageVersionsCentrally=false to netcore_testproject.mustache.
    • Align test .csproj with client .csproj so tests build under CPM.

Written for commit 889d8fb. Summary will update on new commits.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 65 files

@wturk wturk changed the title [csharp] Fix/overide central package versions for csharp test projects [csharp] Fix/override central package versions for csharp test projects Mar 2, 2026
@wing328 wing328 added this to the 7.21.0 milestone Mar 2, 2026
@wing328 wing328 merged commit 910caaa into OpenAPITools:master Mar 2, 2026
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][csharp] Client test projects are generated without ManagePackageVersionsCentrally override

2 participants