Add scalafmt (plugin) to scala-akka client generator#23296
Add scalafmt (plugin) to scala-akka client generator#23296Desel72 wants to merge 1 commit intoOpenAPITools:masterfrom
Conversation
|
Hi @wing328 I opened first PR. could you review it and share any feedback? |
There was a problem hiding this comment.
No issues found across 6 files
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
|
merged via #23299 (you as co-author) with updated tests. thanks for the contribution. |
|
Hi @wing328, thank you for your response. However, I was hoping to have a merged PR on my account rather than a closed one or just the contributor badge. |
can you file a PR to update the following scala client generator with the scalafmt plugin? i'll let you deal with any issues that come up and have your PR merged . |
|
@wing328 I will Open PR soon. thank you. |
Adds scalafmt (
.scalafmt.conf) andsbt-scalafmtplugin to thescala-akkaclient generator for consistent code formatting.Follows the pattern established in #23273 for
scala-sttp4.Refs #23274
PR checklist
masterSummary by cubic
Adds Scalafmt to the
scala-akkaclient generator to ensure consistent formatting by generating a.scalafmt.confand enabling thesbt-scalafmtplugin.project/plugins.sbtwithsbt-scalafmtversion2.5.6..scalafmt.conf(Scalafmt3.10.6, Scala 2.13 dialect) via template.ScalaAkkaClientCodegensupporting files.Written for commit 6171846. Summary will update on new commits.