Skip to content

Add scalafmt plugin to scala-pekko client generator#23362

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
YB0y:feat/scala-pekko-scalafmt
Mar 27, 2026
Merged

Add scalafmt plugin to scala-pekko client generator#23362
wing328 merged 1 commit intoOpenAPITools:masterfrom
YB0y:feat/scala-pekko-scalafmt

Conversation

@YB0y
Copy link
Copy Markdown
Contributor

@YB0y YB0y commented Mar 26, 2026

Adds scalafmt (Scalafmt 3.10.6, Scala 2.13 dialect) and sbt-scalafmt plugin (2.5.6) to the scala-pekko client generator, following the same pattern as #23273 (scala-sttp4).

Part of #23274

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Add scalafmt support to the Scala Pekko client generator to enforce consistent formatting in generated clients. Uses Scalafmt 3.10.6 with the Scala 2.13 dialect and the sbt-scalafmt plugin 2.5.6. Part of #23274 to standardize formatting across Scala generators.

  • New Features
    • Generate .scalafmt.conf with the shared config (version 3.10.6, Scala 2.13).
    • Add project/plugins.sbt with sbt-scalafmt 2.5.6.
    • Wire templates in ScalaPekkoClientCodegen so new clients include both files.
    • Update Scala Pekko petstore sample to reflect the new files.

Written for commit ea44380. Summary will update on new commits.

@YB0y
Copy link
Copy Markdown
Contributor Author

YB0y commented Mar 26, 2026

Hi @wing328 Could you please review this PR and if it looks fine, could you merge this?

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files


Since this is your first cubic review, here's how it works:

  • cubic automatically reviews your code and comments on bugs and improvements
  • Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
  • Add one-off context when rerunning by tagging @cubic-dev-ai with guidance or docs links (including llms.txt)
  • Ask questions if you need clarification on any suggestion

@wing328 wing328 merged commit f5a4bee into OpenAPITools:master Mar 27, 2026
20 checks passed
@wing328 wing328 added this to the 7.22.0 milestone Mar 27, 2026
@YB0y
Copy link
Copy Markdown
Contributor Author

YB0y commented Mar 27, 2026

@wing328 Thank you for merging.
Shall I open more PRs for others?

@YB0y YB0y deleted the feat/scala-pekko-scalafmt branch March 27, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants