Add scalafmt plugin to scala-pekko client generator#23362
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Mar 27, 2026
Merged
Add scalafmt plugin to scala-pekko client generator#23362wing328 merged 1 commit intoOpenAPITools:masterfrom
wing328 merged 1 commit intoOpenAPITools:masterfrom
Conversation
Contributor
Author
|
Hi @wing328 Could you please review this PR and if it looks fine, could you merge this? |
Contributor
There was a problem hiding this comment.
No issues found across 6 files
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Contributor
Author
|
@wing328 Thank you for merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds scalafmt (Scalafmt 3.10.6, Scala 2.13 dialect) and sbt-scalafmt plugin (2.5.6) to the scala-pekko client generator, following the same pattern as #23273 (scala-sttp4).
Part of #23274
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Add
scalafmtsupport to the Scala Pekko client generator to enforce consistent formatting in generated clients. Uses Scalafmt 3.10.6 with the Scala 2.13 dialect and thesbt-scalafmtplugin 2.5.6. Part of #23274 to standardize formatting across Scala generators..scalafmt.confwith the shared config (version 3.10.6, Scala 2.13).project/plugins.sbtwithsbt-scalafmt2.5.6.ScalaPekkoClientCodegenso new clients include both files.Written for commit ea44380. Summary will update on new commits.