feat(dart-dio): add methods to remove auth tokens in api client#23386
feat(dart-dio): add methods to remove auth tokens in api client#23386wing328 merged 1 commit intoOpenAPITools:masterfrom
Conversation
for other clients, if the token is set to empty string or null, the auth header or query parameter won't be set. is dart client behaving the same way? |
It seems to be not like it. Neither in the Code (Looking at e.g. Looking at the Design-Choice in the PR, a behavior that is similar to other clients would imho make methods like the |
|
👌 understood we can give this a try for sure |
There is currently no way to easily remove a previously set auth token. Adding these methods will provide a convenient way to 'revoke' tokens. Design-Choice: Adding those new methods is a better alternative as just making the values of existing methods nullable, as e.g. #setBasicAuth(String, String, String) has two value parameters, which then would have to be checked for nullability and special handling would be required if only one value is null. This would result in a less clear API. By adding new methods following the naming #removeXY(String) no ambiguity is added and a clear API is kept.
There is currently no way to easily remove a previously set auth token. Adding these methods will provide a convenient way to 'revoke' tokens.
Design-Choice:
Adding those new methods is a better alternative as just making the values of existing methods nullable, as e.g. #setBasicAuth(String, String, String) has two value parameters, which then would have to be checked for nullability and special handling would be required if only one value is null. This would result in a less clear API. By adding new methods following the naming #removeXY(String) no ambiguity is added and a clear API is kept.
Output was tested and is working as expected.
Mentions as this only targets Dart code (like required in the PR checklist): @jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Added removal methods for auth credentials in
dart-dioAPI clients so apps can revoke tokens/keys at runtime without recreating the client.removeOAuthToken(name)removes tokens fromOAuthInterceptor.removeBearerAuth(name)removes tokens fromBearerAuthInterceptor.removeBasicAuth(name)removes credentials fromBasicAuthInterceptor.removeApiKey(name)removes keys fromApiKeyAuthInterceptor.samples/openapi3dart-dioclients to include these methods.Written for commit 21ee2e0. Summary will update on new commits.