Skip to content

Fix pattern in scala aka http server generator#23423

Merged
wing328 merged 2 commits intomasterfrom
scala-akka-pattern
Apr 2, 2026
Merged

Fix pattern in scala aka http server generator#23423
wing328 merged 2 commits intomasterfrom
scala-akka-pattern

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Apr 2, 2026

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Fixes regex pattern escaping in the scala-akka-http-server generator so Akka HTTP PathMatchers render raw regex and match correctly. In api.mustache, wraps {{{pattern}}} in a Scala triple-quoted string ("""...""") to avoid HTML and string escaping of backslashes and other regex characters.

Written for commit 49d774e. Summary will update on new commits.

@wing328 wing328 changed the title fix pattern in scala aka http server generator Fix pattern in scala aka http server generator Apr 2, 2026
@wing328 wing328 added this to the 7.22.0 milestone Apr 2, 2026
@wing328 wing328 marked this pull request as ready for review April 2, 2026 06:33
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="modules/openapi-generator/src/main/resources/scala-akka-http-server/api.mustache">

<violation number="1" location="modules/openapi-generator/src/main/resources/scala-akka-http-server/api.mustache:59">
P2: Raw pattern injection into a Scala double-quoted literal can generate invalid code when the regex contains `"`. Render the pattern in a Scala triple-quoted string to preserve regex characters without breaking string delimiters.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread modules/openapi-generator/src/main/resources/scala-akka-http-server/api.mustache Outdated
…erver/api.mustache

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
@wing328 wing328 merged commit fa7f5a2 into master Apr 2, 2026
15 checks passed
@wing328 wing328 deleted the scala-akka-pattern branch April 2, 2026 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant