Skip to content

Add scalafmt plugin to scala-finch generator#23459

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
volcano303:add-scalafmt-scala-finch
Apr 7, 2026
Merged

Add scalafmt plugin to scala-finch generator#23459
wing328 merged 1 commit intoOpenAPITools:masterfrom
volcano303:add-scalafmt-scala-finch

Conversation

@volcano303
Copy link
Copy Markdown
Contributor

@volcano303 volcano303 commented Apr 7, 2026

Adds scalafmt (Scalafmt 3.10.6, Scala 2.12 dialect) and sbt-scalafmt plugin (2.5.6) to the scala-finch generator, following the same pattern as #23273 (scala-sttp4) and #23378 (scala-sttp4-jsoniter).

The sbt-scalafmt plugin line is appended to the existing project/plugins.sbt.

Partially addresses #23274

cc @clasnake @shijinkui @ramzimaalej @chameleon82 @Bouillie @Fish86

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Add Scalafmt to the Scala Finch server generator to auto-format generated code. Ships a .scalafmt.conf and adds the sbt-scalafmt plugin for easy formatting.

  • New Features
    • Generate .scalafmt.conf (Scalafmt 3.10.6, Scala 2.12 dialect) via scalafmt.mustache.
    • Append org.scalameta sbt-scalafmt 2.5.6 to project/plugins.sbt.
    • Update Scala Finch sample to include the config and tidy imports.

Written for commit 54df45b. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 10 files

@wing328
Copy link
Copy Markdown
Member

wing328 commented Apr 7, 2026

CI failure not related to this change

i'll take another look at the CI failure tomorrow

@wing328 wing328 merged commit 682e45c into OpenAPITools:master Apr 7, 2026
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants