Skip to content

Mark scala-finch generator as deprecated#23484

Merged
wing328 merged 1 commit intomasterfrom
scala-finch-depreacated
Apr 8, 2026
Merged

Mark scala-finch generator as deprecated#23484
wing328 merged 1 commit intomasterfrom
scala-finch-depreacated

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Apr 8, 2026

Mark scala-finch generator as deprecated (renamed to scala-finch-deprecated) as finch project is no longer maintained.

FYI @clasnake (2017/07), @shijinkui (2018/01), @ramzimaalej (2018/03), @chameleon82 (2020/03), @Bouillie (2020/04) @Fish86 (2023/06)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Deprecate the Scala Finch generator since Finch is no longer maintained. The generator id is now scala-finch-deprecated; docs, samples, and CI were updated accordingly.

  • Refactors

    • Set generator stability to DEPRECATED via GeneratorMetadata and updated help text.
    • Renamed generator id from scala-finch to scala-finch-deprecated.
    • Updated docs (generators list and page renamed) and removed samples/server/petstore/scala-finch/** plus its CI workflow.
    • Removed bin/configs/unmaintained/scala-finch.yaml.
  • Migration

    • If you still need it, use -g scala-finch-deprecated.
    • Consider migrating to scala-http4s-server, scala-akka-http-server, or scala-play-server.

Written for commit 23019f4. Summary will update on new commits.

@wing328 wing328 added this to the 7.22.0 milestone Apr 8, 2026
@wing328 wing328 marked this pull request as ready for review April 8, 2026 08:32
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 28 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/ScalaFinchServerCodegen.java">

<violation number="1" location="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/ScalaFinchServerCodegen.java:218">
P2: Renaming `getName()` to `scala-finch-deprecated` breaks backward compatibility for existing `-g scala-finch` usage because generator lookup is exact-name based and no alias is provided.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@Override
public String getName() {
return "scala-finch";
return "scala-finch-deprecated";
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Renaming getName() to scala-finch-deprecated breaks backward compatibility for existing -g scala-finch usage because generator lookup is exact-name based and no alias is provided.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/ScalaFinchServerCodegen.java, line 218:

<comment>Renaming `getName()` to `scala-finch-deprecated` breaks backward compatibility for existing `-g scala-finch` usage because generator lookup is exact-name based and no alias is provided.</comment>

<file context>
@@ -209,12 +215,12 @@ public CodegenType getTag() {
     @Override
     public String getName() {
-        return "scala-finch";
+        return "scala-finch-deprecated";
     }
 
</file context>
Fix with Cubic

@wing328 wing328 merged commit f12fe51 into master Apr 8, 2026
28 checks passed
@wing328 wing328 deleted the scala-finch-depreacated branch April 8, 2026 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant