Skip to content

Fix jaxrs-spec CI failures#23523

Merged
wing328 merged 1 commit intomasterfrom
fix-jaxrs-ci
Apr 13, 2026
Merged

Fix jaxrs-spec CI failures#23523
wing328 merged 1 commit intomasterfrom
fix-jaxrs-ci

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Apr 13, 2026

a follow up PR to #23509

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Switch JAX-RS sample configs to the OAS3 Petstore and regenerate samples to align with current generator output, resolving CI snapshot mismatches for jaxrs-spec.
This updates inputs and samples only; no generator logic changes.

  • Bug Fixes
    • Pointed bin/configs/jaxrs-spec-interface*.yaml and jaxrs-spec-quarkus-microprofile-openapi-annotations.yaml to modules/openapi-generator/src/test/resources/3_0/petstore.yaml (was OAS2).
    • Regenerated samples/server/petstore/jaxrs-spec-interface* using OAS3 Petstore: removed legacy “fake” endpoints/models and refreshed openapi.yaml.
    • Fixed generated API signatures and annotations:
      • Renamed path params order_idorderId.
      • Renamed request params bodypet/user; added @Produces to addPet; updated auth annotations.
      • Dropped RestApplication/RestResourceRoot scaffolding.
    • Updated model docs (e.g., Category, Pet, Tag, User, Order, ModelApiResponse) and removed unused models to match OAS3 schema.
    • CI: sample outputs now match expectations and JAX-RS jobs should pass.

Written for commit f448007. Summary will update on new commits.

@wing328 wing328 added this to the 7.22.0 milestone Apr 13, 2026
@wing328 wing328 changed the title fix jaxrs CI failures Fix jaxrs-spec CI failures Apr 13, 2026
@wing328 wing328 marked this pull request as ready for review April 13, 2026 08:58
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 169 files

Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed. cubic prioritises the most important files to review.

@wing328 wing328 merged commit cf4ced7 into master Apr 13, 2026
58 checks passed
@wing328 wing328 deleted the fix-jaxrs-ci branch April 13, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant