Skip to content

[java][spring] fix: disableDiscriminatorJsonIgnoreProperties not working#23640

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
knikolos:fix-spring-disableDiscriminatorJsonIgnoreProperties
Apr 29, 2026
Merged

[java][spring] fix: disableDiscriminatorJsonIgnoreProperties not working#23640
wing328 merged 1 commit intoOpenAPITools:masterfrom
knikolos:fix-spring-disableDiscriminatorJsonIgnoreProperties

Conversation

@knikolos
Copy link
Copy Markdown
Contributor

@knikolos knikolos commented Apr 28, 2026

Config option disableDiscriminatorJsonIgnoreProperties added in #22528 and documented here https://github.com/dnowo/openapi-generator/blob/0691dc80373076b0409d688774efe5ab7204e44d/docs/generators/spring.md?plain=1#L45 was not taken in account during generation, this PR fixes that.

@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@knikolos knikolos changed the title fix: disableDiscriminatorJsonIgnoreProperties no working in Spring ge… [java-spring] fix: disableDiscriminatorJsonIgnoreProperties no working in Spring ge… Apr 28, 2026
@knikolos knikolos changed the title [java-spring] fix: disableDiscriminatorJsonIgnoreProperties no working in Spring ge… [java][spring] fix: disableDiscriminatorJsonIgnoreProperties no working in Spring ge… Apr 28, 2026
@knikolos knikolos marked this pull request as ready for review April 28, 2026 08:11
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@wing328 wing328 added this to the 7.23.0 milestone Apr 29, 2026
@wing328 wing328 changed the title [java][spring] fix: disableDiscriminatorJsonIgnoreProperties no working in Spring ge… [java][spring] fix: disableDiscriminatorJsonIgnoreProperties not working Apr 29, 2026
@wing328 wing328 merged commit 5acb7cc into OpenAPITools:master Apr 29, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants