[GRADLE-WRAPPER] bug fix - pass maven java_home to gradle correctly#23646
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Apr 28, 2026
Merged
Conversation
…sistent JDK usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My previous attempt to pass identical java_home used for maven to the underlying gradle was incorrect. I only noticed on my other machine where the default java_home points to java 25 which is not compatible with the kotlin version used by the gradle maven wrapper.
So this is another attempt to make it work. I tested locally that the correct java_home is propagated now.
Impact of the current incorrect implementation - there is no practical impact. It simply does not work (the same way it did not work before my original attempt to link the java_home). And it definitely has no practical impact on the released version as this practically only comes into play when building locally
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Ensure Gradle uses the same JDK as Maven by passing Maven’s
${java.home}via the plugin’sjavaHomesetting instead of-Dorg.gradle.java.home. Prevents Gradle from picking a different system JDK (e.g., JDK 25 when Maven runs on JDK 21).Written for commit a2f6da0. Summary will update on new commits. Review in cubic