Skip to content

A follow-up PR to #22726 (update workflow, samples)#23865

Merged
wing328 merged 2 commits into
masterfrom
22726-followup
May 24, 2026
Merged

A follow-up PR to #22726 (update workflow, samples)#23865
wing328 merged 2 commits into
masterfrom
22726-followup

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented May 24, 2026

a follow-up pr to #22726

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Streamlined the Spring HTTP Interface OAuth sample to a minimal Petstore “addPet” client and wired it into the JDK17 workflow to speed up generation and CI validation.

  • Refactors

    • Switched generator input to modules/openapi-generator/src/test/resources/3_0/petstore-addpet-only.yaml.
    • Renamed sample artifact to spring-http-interface-oauth-petstore.
    • Pruned generated code to only PetApi and related DTOs; removed unused APIs/models and beans.
    • Updated PetApi.addPet to return ResponseEntity<PetDto> and accept application/json and application/xml.
    • Changed PetDto.photoUrls from Set to List; made CategoryDto.name nullable and removed default; updated model docs.
    • Simplified README and allowed it to be regenerated by removing the ignore rule.
  • CI

    • Added samples/client/petstore/spring-http-interface-oauth/** to the Spring JDK17 workflow triggers and build matrix.

Written for commit ae3f890. Summary will update on new commits. Review in cubic

@wing328 wing328 changed the title 22726 followup A follow-up PR to #22726 (update workflow, samples) May 24, 2026
@wing328 wing328 marked this pull request as ready for review May 24, 2026 15:33
@wing328 wing328 merged commit 74f7b07 into master May 24, 2026
122 checks passed
@wing328 wing328 added this to the 7.23.0 milestone Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant