-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
[TypeScript][Node] async promises and imports #2452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TypeScript][Node] async promises and imports #2452
Conversation
|
cc |
macjohnny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Update samples via bffca05. Let's see if all the tests pass |
|
Blimey do they always take this long to start? |
|
Not sure why the Travis job was omitted but local test result looks good: |
|
Will this now be part of version 3 or 4 or both? When will I be safe to reinstall with Homebrew for example? |
|
This is included in the 4.x. Please refer to #1790 on how to brew install the latest master. |
|
OK I did that and ended up with 4.0.0-beta but that doesn't contain this fix? |
|
@kpturner you need to adapt this file: wing328/homebrew-core@6e809df#diff-7212f3680bef582a293d6249adbf98c3R8 |
|
But there is no |
|
I corrected my comment |
|
When I checked out |
|
you need to change the url from |
|
OK - and I guess the |
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
Small modifications to the typescript-node mustache template to ensure that the result will transpile.