Skip to content

Conversation

@kpturner
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Small modifications to the typescript-node mustache template to ensure that the result will transpile.

@macjohnny
Copy link
Member

cc
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10)

Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 added this to the 4.0.0 milestone Mar 20, 2019
@wing328 wing328 changed the title async promises and imports [TypeScript][Node] async promises and imports Mar 20, 2019
@wing328
Copy link
Member

wing328 commented Mar 20, 2019

Update samples via bffca05. Let's see if all the tests pass

@kpturner
Copy link
Contributor Author

Blimey do they always take this long to start?

@wing328
Copy link
Member

wing328 commented Mar 21, 2019

Not sure why the Travis job was omitted but local test result looks good:

Checking deserialization.
Checking serialization
Created pet with ID 18291
Updated pet using POST body
Updated pet using POST form
Uploaded image
Got pet by ID: {"id":18291,"category":{"id":18291,"name":"TS category 1"},"name":"TypeScriptDoggie","photoUrls":["http://url1","http://url2"],"tags":[{"id":18291,"name":"TS tag 1"}],"status":"pending"}
EnumValue:  pending
Typeof EnumValue: string
Res: pending
Deleted pet
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:44 min
[INFO] Finished at: 2019-03-21T22:25:45+08:00
[INFO] ------------------------------------------------------------------------

@wing328 wing328 merged commit 2f8e4fe into OpenAPITools:master Mar 21, 2019
@kpturner
Copy link
Contributor Author

Will this now be part of version 3 or 4 or both? When will I be safe to reinstall with Homebrew for example?

@wing328
Copy link
Member

wing328 commented Mar 21, 2019

This is included in the 4.x. Please refer to #1790 on how to brew install the latest master.

@kpturner
Copy link
Contributor Author

OK I did that and ended up with 4.0.0-beta but that doesn't contain this fix?

@macjohnny
Copy link
Member

macjohnny commented Mar 21, 2019

@kpturner
Copy link
Contributor Author

But there is no Formula/openapi-generator.rb in master?

@macjohnny
Copy link
Member

I corrected my comment

@kpturner
Copy link
Contributor Author

When I checked out git checkout openapi-generator-4.0.0-beta it already contained the code that you suggested I change so unfortunately I am still no further ahead. The only way I seem to be able to run with this fixed is from my original maven build.

@macjohnny
Copy link
Member

you need to change the url from https://search.maven.org/remotecontent?filepath=org/openapitools/openapi-generator-cli/4.0.0-beta/openapi-generator-cli-4.0.0-beta.jar to https://oss.sonatype.org/content/repositories/snapshots/org/openapitools/openapi-generator-cli/4.0.0-SNAPSHOT/openapi-generator-cli-4.0.0-20190321.151032-428.jar

@kpturner
Copy link
Contributor Author

OK - and I guess the sha256 also needs to change?

@kpturner kpturner deleted the Fix-typescript-node-generator branch March 25, 2019 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants