[typescript] Introduce "enumPropertyNaming" option#5162
[typescript] Introduce "enumPropertyNaming" option#5162macjohnny merged 6 commits intoOpenAPITools:masterfrom
Conversation
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
|
note: instead of fake commits, you can also close and re-open the PR to trigger CI |
There was a problem hiding this comment.
maybe the available values in ENUM_PROPERTY_NAMING_TYPE could be listed automatically, so the comment will not be outdated
There was a problem hiding this comment.
Good idea, will do!
There was a problem hiding this comment.
maybe you would want to add a test for the non-original case, too?
|
there seems to be some issue with the option parsing, see https://app.shippable.com/github/OpenAPITools/openapi-generator/runs/14327/1/console |
26a9a1b to
92329c8
Compare
Looks like Kotlin build is broken - no idea why. Rebasing my branch from the latest master to see if it's gonna self-resolve |
|
The last CI step still fails with a kotlin-related error. |
This works similar to the existing "modelPropertyNaming", but applies to enum var names instead of model properties.
Default value is "PascalCase", which reflects the way it works currently.
Personally, I only need this configurable in the typescript-angular generator now. However, since the enum var name transformation is implemented in the abstract typescript class, I thought it would be beneficial to keep consistency across multiple typescript generators. After all, this is quite a generic setting, not specific to a particular framework.
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @nicokoenig @topce @akehir @petejohansonxo