[core] Add support for multipart/ mediatype and encoding params#5613
[core] Add support for multipart/ mediatype and encoding params#5613zhemant wants to merge 14 commits intoOpenAPITools:masterfrom
Conversation
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
|
@wing328 I have added the PR again for support of multipart and encoding. I will add tests for these additions |
|
Added test yaml file and test function to verify required flag for body in formparams, multipart related contenttype and its flags, encoding objects for multipart |
…r when body doesnot have form params
|
@wing328 the PR is complete from my side. Please check |
|
cc @OpenAPITools/generator-core-team |
|
A conflict was generated. I fixed the conflict. Any other comments or suggestions on the PR? |
|
@wing328 there are no comments on the PR, can it be merged, please? |
|
@wing328 any inputs, please? |
|
Sorry didn't have time to review yet. Will try to get it done before 5.x release. |
|
no problem. Take your time. I will solve conflicts once you check it. Whenever I solve conflicts there are new merge requests which again generate conflicts. |
|
@wing328 any updates on this? |
|
@wing328 i've run into this issue as well. updates? |
|
@wing328 Could we please try to get this merged? I will fix the conflicts if we can merge. |
|
Seems like wanting to upload different content-types within a multipart upload is table stakes for an API. Is there another way we should be doing this? If not, what are the changes this gets merged? |
|
Hello. Any updates on how to add encoding to multipart requests or is there a workaround available? Seems this PR is abandoned, but the issue is still present. In my case I want to send an integer on the request. And the failure is: I am using the python generated client with v7.7.0 openapi generator version. Also, I can reproduce the same behavior using curl: I want to achieve the same with the python generated client. |
|
From the latest code, I see there is some support for encoding, I am not sure. But if multipart/related is still interesting for response, then I would be happy to create another clean PR with the changes. |
The PR will add support for
Multipart Requests: https://swagger.io/docs/specification/describing-request-body/multipart-requests/
Encoding: https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.3.md#encoding-object
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.