[Java] Enhancements for HTTP message signature#6090
Merged
wing328 merged 8 commits intoOpenAPITools:masterfrom May 2, 2020
Merged
[Java] Enhancements for HTTP message signature#6090wing328 merged 8 commits intoOpenAPITools:masterfrom
wing328 merged 8 commits intoOpenAPITools:masterfrom
Conversation
…ava-http-signature
…ava-http-signature
This reverts commit 3b52778.
Member
|
FYI. I ran |
michaelpro1
pushed a commit
to michaelpro1/openapi-generator
that referenced
this pull request
May 7, 2020
* Add code comments * Change 'setup' method to setPrivateKey * Add support for configuring digest algorithm * run script in bin directory * format generated code * Revert "format generated code" This reverts commit 3b52778.
MikailBag
pushed a commit
to MikailBag/openapi-generator
that referenced
this pull request
May 31, 2020
* Add code comments * Change 'setup' method to setPrivateKey * Add support for configuring digest algorithm * run script in bin directory * format generated code * Revert "format generated code" This reverts commit 3b52778.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Besides the changes in this PR, I had to submit 3 PRs in HTTP signature for Java:
tomitribe/http-signatures-java#31
tomitribe/http-signatures-java#32
tomitribe/http-signatures-java#33
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.