[Java] Escaping properties to better handle special characters#628
Merged
jmini merged 4 commits intoOpenAPITools:masterfrom Jul 24, 2018
Merged
[Java] Escaping properties to better handle special characters#628jmini merged 4 commits intoOpenAPITools:masterfrom
jmini merged 4 commits intoOpenAPITools:masterfrom
Conversation
Fixed header generation. Previously the key was used as value parameter.
Special characters were not escaped for properties and a malformed Java object was created.
Old method from testing
jmini
approved these changes
Jul 24, 2018
wing328
approved these changes
Jul 24, 2018
wing328
changed the title
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.1.x,4.0.x. Default:master.Description of the PR
Currently the CodeGenerator did not escape invalid properties for java and passed them as they are to the created java file. By this, a malformed Java file is generated, that can not be compiled and used. Since json and yaml allow every combination for variables, these need to be escaped and cammelCased.