Skip to content

[haskell-http-client] regen samples#709

Merged
jonschoning merged 2 commits intoOpenAPITools:masterfrom
jonschoning:haskell-http-client
Aug 5, 2018
Merged

[haskell-http-client] regen samples#709
jonschoning merged 2 commits intoOpenAPITools:masterfrom
jonschoning:haskell-http-client

Conversation

@jonschoning
Copy link
Copy Markdown
Contributor

No description provided.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Aug 2, 2018

@jonschoning shall we add the following to ./bin/utils/ensure-up-to-date to ensure the haskell-http-client samples are always up-to-date?

./bin/haskell-http-client-petstore.sh

@wing328 wing328 added this to the 3.2.0 milestone Aug 2, 2018
@jonschoning
Copy link
Copy Markdown
Contributor Author

jonschoning commented Aug 2, 2018

Actually the example app for haskell-http-client is built against the OAS3 yaml file instead of the OAS2 yaml file, so due to that, I would be ok with adding bin/openapi3/haskell-http-client-petstore.sh to ensure-up-todate (if we only wanted the OAS2 input file e.g. bin/haskell-http-client-petstore.sh then i'd have to fix the example app in the sample folder to use types from the OAS2 input yaml file). let me know if you ensure-up-to-date cares whether it's using the the bin/ scripts or the bin/openapi3 scripts.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Aug 2, 2018

Feel free to use scripts in bin/openapi3/scripts, e.g. https://github.com/OpenAPITools/openapi-generator/blob/master/bin/utils/ensure-up-to-date#L27

@jonschoning
Copy link
Copy Markdown
Contributor Author

done

@jonschoning jonschoning force-pushed the haskell-http-client branch 2 times, most recently from 85154cf to 2e1e2a0 Compare August 4, 2018 21:26
@jonschoning jonschoning force-pushed the haskell-http-client branch from 2e1e2a0 to dc75959 Compare August 4, 2018 22:52
@jonschoning jonschoning merged commit f6c2105 into OpenAPITools:master Aug 5, 2018
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* [haskell-http-client] regen samples

* ensure the haskell-http-client samples are always up-to-date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants