Skip to content

Fix petstore security spec to address validation errors#739

Merged
wing328 merged 1 commit intomasterfrom
fix_security
Aug 6, 2018
Merged

Fix petstore security spec to address validation errors#739
wing328 merged 1 commit intomasterfrom
fix_security

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Aug 5, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

To fix #734

@wing328 wing328 added this to the 3.2.0 milestone Aug 5, 2018
@wing328 wing328 requested a review from ybelenko August 5, 2018 08:38
@wing328 wing328 changed the title Fix petstore security spec to remove validation errors Fix petstore security spec to address validation errors Aug 5, 2018
Copy link
Copy Markdown
Contributor

@ybelenko ybelenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked PR locally, and it solves addressed issue. 👍

@wing328 wing328 merged commit 1ab4fe4 into master Aug 6, 2018
@wing328 wing328 deleted the fix_security branch August 6, 2018 09:02
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Slim] Security samples script fails

2 participants