Skip to content

[C#][netcore] Add test for AdditionalProperties in both child and parent#7921

Merged
wing328 merged 2 commits intomasterfrom
csharp-fix-ap
Nov 13, 2020
Merged

[C#][netcore] Add test for AdditionalProperties in both child and parent#7921
wing328 merged 2 commits intomasterfrom
csharp-fix-ap

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Nov 11, 2020

  • Add test for AdditionalProperties in both child and parent

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02)

@auto-labeler
Copy link
Copy Markdown

auto-labeler Bot commented Nov 11, 2020

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@wing328 wing328 added this to the 5.0.0 milestone Nov 11, 2020
@wing328 wing328 merged commit a3a0af7 into master Nov 13, 2020
@wing328 wing328 deleted the csharp-fix-ap branch November 13, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant