Skip to content

[typescript-axios] Fix missing parenthesis in apiInner.mustache#7923

Merged
macjohnny merged 1 commit intoOpenAPITools:masterfrom
dvarnai:patch-1
Nov 12, 2020
Merged

[typescript-axios] Fix missing parenthesis in apiInner.mustache#7923
macjohnny merged 1 commit intoOpenAPITools:masterfrom
dvarnai:patch-1

Conversation

@dvarnai
Copy link
Copy Markdown
Contributor

@dvarnai dvarnai commented Nov 12, 2020

A closing parenthesis was missing in apiInner.mustache, causing invalid generated api.ts in rare cases.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

@auto-labeler
Copy link
Copy Markdown

auto-labeler Bot commented Nov 12, 2020

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

Copy link
Copy Markdown
Contributor

@amakhrov amakhrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @dvarnai ! The fix makes total sense to me.

I assume samples didn't change because test api specs don't have such a case.
Yet for better visibility - could you please post an example of api-spec that demonstrates the issue, and the generated output before and after the fix?

Copy link
Copy Markdown
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macjohnny macjohnny merged commit 3b84e8b into OpenAPITools:master Nov 12, 2020
@macjohnny macjohnny added this to the 5.0.0 milestone Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants