Skip to content

Fix duplicated mappedModels#7924

Merged
wing328 merged 7 commits intomasterfrom
fix_dup_map
Nov 20, 2020
Merged

Fix duplicated mappedModels#7924
wing328 merged 7 commits intomasterfrom
fix_dup_map

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Nov 12, 2020

Fix duplicated mappedModels to ensure mappingName must be unique

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @OpenAPITools/generator-core-team

@wing328 wing328 marked this pull request as ready for review November 12, 2020 15:34
@wing328 wing328 added this to the 5.0.0 milestone Nov 16, 2020
@wing328 wing328 merged commit dd26e40 into master Nov 20, 2020
@wing328 wing328 deleted the fix_dup_map branch November 22, 2020 08:42
// add only if the mapping names are not the same
boolean matched = false;
for (MappedModel uniqueDescendant: uniqueDescendants) {
if (uniqueDescendant.getMappingName().equals(otherDescendant.getMappingName())) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not to check by if (uniqueDescendant.getModelName().equals(otherDescendant.getModelName())) { to avoid duplicates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants