[dart][dart-dio] Improve form param handling, respect required flag#8369
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Jan 22, 2021
Merged
Conversation
* simplify template * respect required flag (only null check when not rquired) * minor formatting
kuhnroyal
force-pushed
the
dart-dio/form-param-improvements
branch
from
da76a07 to
dcaea95
Compare
josh-burton
approved these changes
Jan 7, 2021
agilob
approved these changes
Jan 7, 2021
| formData['name'] = parameterToString(_serializers, name); | ||
| formData['status'] = parameterToString(_serializers, status); | ||
| final formData = <String, dynamic>{ | ||
| if (name != null) r'name': parameterToString(_serializers, name), |
Contributor
There was a problem hiding this comment.
I would put null-check inside parameterToString to remove repeating code, what's the effect of formData['name'] = null ?
Contributor
Author
There was a problem hiding this comment.
There is one but it defaults to ''. I am unsure what the consequences are if I remove this.
Contributor
Author
There was a problem hiding this comment.
Also the null-check is only done when the param is not required.
| ]; | ||
|
|
||
| var serializedBody = body; | ||
| final serializedBody = body; |
Contributor
Author
There was a problem hiding this comment.
We expect the serializedBody below.
wing328
reviewed
Jan 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master,5.1.x,6.0.xCC @swipesight (2018/09) @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12)