Skip to content

Fix README typo for Crystal#8470

Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom
dukenguyenxyz:patch-1
Jan 19, 2021
Merged

Fix README typo for Crystal#8470
wing328 merged 3 commits intoOpenAPITools:masterfrom
dukenguyenxyz:patch-1

Conversation

@dukenguyenxyz
Copy link
Copy Markdown
Contributor

@dukenguyenxyz dukenguyenxyz commented Jan 19, 2021

Simple Typo fix

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Jan 19, 2021

@dukeraphaelng thanks for the PR. You need to update the mustache template as well: https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/crystal/README.mustache

Copy link
Copy Markdown
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit 8b2ac7b into OpenAPITools:master Jan 19, 2021
@dukenguyenxyz dukenguyenxyz deleted the patch-1 branch January 19, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants