Skip to content

[dart][dart-dio] Fix missing byte response cast#8985

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
kuhnroyal:dart-dio/fix-byte-response
Mar 17, 2021
Merged

[dart][dart-dio] Fix missing byte response cast#8985
wing328 merged 1 commit intoOpenAPITools:masterfrom
kuhnroyal:dart-dio/fix-byte-response

Conversation

@kuhnroyal
Copy link
Copy Markdown
Contributor

@kuhnroyal kuhnroyal commented Mar 16, 2021

There doesn't seem to be an example for this.
Fixes #8878

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

CC @agilob

There doesn't seem to be an example.
@agilob
Copy link
Copy Markdown
Contributor

agilob commented Mar 17, 2021

no 'file' type used in pet clinic 3? I'm a bit surprised schema doesnt have it, I thought there was image field for pet that was file. huh

@wing328
Copy link
Copy Markdown
Member

wing328 commented Mar 17, 2021

no 'file' type used in pet clinic 3? I'm a bit surprised schema doesnt have it, I thought there was image field for pet that was file. huh

That was for testing file upload (parameter).

For return type, looks like we've not added one for type: string, format: binary yet. I'll try to add one later this week

@wing328 wing328 added this to the 5.1.0 milestone Mar 17, 2021
@wing328 wing328 merged commit 45a3764 into OpenAPITools:master Mar 17, 2021
@kuhnroyal kuhnroyal deleted the dart-dio/fix-byte-response branch March 17, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][dart-dio][client] new analysis_options.yaml triggers error on response which is bytes

3 participants