Skip to content
This repository was archived by the owner on Nov 24, 2022. It is now read-only.

Fix OAS2 parameter conversion#1

Merged
wing328 merged 1 commit into2.0-OpenAPIToolsfrom
fix-oas2-parameter-conversion
May 16, 2018
Merged

Fix OAS2 parameter conversion#1
wing328 merged 1 commit into2.0-OpenAPIToolsfrom
fix-oas2-parameter-conversion

Conversation

@ackintosh
Copy link
Copy Markdown

@ackintosh ackintosh commented May 12, 2018

Issue: swagger-api#690

This PR fixes OAS2 parameter conversion according to the summary below:

OAS v2: in OAS v2: collectionFormat OAS v3: style OAS v3: explode
query csv form false
query multi form true
header csv simple false(default)
path csv simple false(default)
* ssv spaceDelimited false(default)
* pipes pipeDelimited false(default)
* tsv - -

@jmini
Copy link
Copy Markdown
Member

jmini commented May 12, 2018

@wing328 can we setup the ci for this fork?

@wing328
Copy link
Copy Markdown
Member

wing328 commented May 12, 2018

Sure. I can set it up later.

@wing328
Copy link
Copy Markdown
Member

wing328 commented May 13, 2018

CI setup via #2

Instead of merging it into 2.0, what about creating a branch "2.0-OpenAPITools" for enhancements required for OpenAPITools-related projects? (so that it will be clearer this branch is for "OpenAPITools"

@ackintosh
Copy link
Copy Markdown
Author

I agree with that 💡

@jmini jmini changed the base branch from 2.0 to 2.0-OpenAPITools May 13, 2018 13:18
@jmini jmini changed the base branch from 2.0-OpenAPITools to 2.0 May 13, 2018 13:18
@jmini jmini changed the base branch from 2.0 to 2.0-OpenAPITools May 13, 2018 13:19
@jmini
Copy link
Copy Markdown
Member

jmini commented May 16, 2018

As I wrote in OpenAPITools/openapi-generator#68 I hope that we will be able to get swagger-api#696 (replaced by swagger-api#711) merged.

@wing328 wing328 merged commit 80ace3f into 2.0-OpenAPITools May 16, 2018
wing328 pushed a commit that referenced this pull request Dec 18, 2018
jmini pushed a commit that referenced this pull request Dec 20, 2018
Update json-schema-validator (SONATYPE-2015-0090)
ackintosh pushed a commit to ackintosh/swagger-parser that referenced this pull request May 18, 2019
Update to latest swagger-api/swagger-parser
jmini pushed a commit that referenced this pull request Aug 22, 2019
Merge pull request swagger-api#1134 from scottr-ad/master
gracekarina pushed a commit to ackintosh/swagger-parser that referenced this pull request Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants