http.nonProxyHosts does not work without http.proxyUser, with quotes and more related issues

[markieww]

The fix #272 to support the http.nonProxyHosts does not work.

We use a configuration with an exception for hosts which should not be routed via a proxy.

For example: -Dhttp.proxyHost=proxy -Dhttp.proxyPort=80 -Dhttps.proxyHost=proxy -Dhttps.proxyPort=80 -Dhttp.nonProxyHosts="localhost|.local|externalhost"

But when sending an AS2-message to https://externalhost:8443/content/foo.bar.AS2Server (configured in partnerships.xml) via OpenAS2 4.0.0 the proxy is still used.

[markieww]

While debugging I found the following issues within the code

1. SystemDefaultRoutePlanner is only used, when http.proxyUser is given

In org.openas2.util.HTTPUtil#setProxyConfig

        final String proxyUser = proxyUser1 == null ? System.getProperty("http.proxyUser") : proxyUser1;
        if (proxyUser == null) {
            return;
        }
        //.. left out for illustration

        SystemDefaultRoutePlanner routePlanner = new SystemDefaultRoutePlanner(null);
        builder.setRoutePlanner(routePlanner);

the SystemDefaultRoutePlanner is only used, when http.proxyUser is given.

Note that SystemDefaultRoutePlanner was introduced by #272

2. SystemDefaultRoutePlanner does not read -Dhttp.nonProxyHosts-Property

When using the SystemDefaultRoutePlanner correctly (f.e. by providing a proxyUser) the nonProxyHost-setting still does not work.
The set proxy in org.openas2.util.HTTPUtil#setProxyConfig won't trigger the detection of -Dhttp.nonProxyHosts in SystemDefaultRoutePlanner (which extends DefaultRoutePlanner, so do not get confused by the screenshot). Thus still using the route through the proxy.

3. http.nonProxyHosts uses quotes incorrectly

Once setting the proxy-instance in org.openas2.util.HTTPUtil#setProxyConfig to null to tigger the detection in SystemDefaultRoutePlanner the nonProxyHost-setting still does not work either.

Regarding https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/net/doc-files/net-properties.html the syntax is to use quotes.

http.nonProxyHosts (default: localhost|127.|[::1])
Indicates the hosts that should be accessed without going through the proxy. Typically this defines internal hosts. The value of this property is a list of hosts, separated by the '|' character. In addition, the wildcard character '' can be used for pattern matching. For example, -Dhttp.nonProxyHosts="*.foo.com|localhost" will indicate that every host in the foo.com domain and the localhost should be accessed directly even if a proxy server is specified.

But in my case (OpenAS2 4.0.0 and Temurin JDK 17) the quotes are not trimmed and must be omitted to make the nonProxyHost-setting work.

Here in the variable view of the debugger you see a string "localhost|local|externalhost"|localhost|127.* which is splitted internally into parts of

• "localhost
• local
• externalhost"
• localhost
• 127.*

and thus non of those patterns match the hostname externalhost of target url https://externalhost:8443/content/foo.bar.AS2Server and the proxy is still used. 😢

[markieww]

Please have a look at my mergerequest #416

[uhurusurfa]

This is now released in v4.1.1