Fix/lazyload-to-eagerload

[Animesh404]

What kind of change does this PR introduce?

a bugfix for #807

Summary

Added joinedload in all the functions called by get_events in order to eagerload them.

Checklist

• My code follows the style guidelines of OpenAdapt
• I have performed a self-review of my code
• If applicable, I have added tests to prove my fix is functional/effective
• I have linted my code locally prior to submission
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (e.g. README.md, requirements.txt)
• New and existing unit tests pass locally with my changes

How can your code be run and tested?
Try running replay via VisualReplayStrategy now it shouldn't throw DetachedInstanceError
python -m openadapt.replay VisualReplayStrategy --instructions "calculate 4*2-1"

[abrichr]

Thank you @Animesh404 ! What do you think about modifying _get to accept an eager parameter instead?

[Animesh404]

Thank you @Animesh404 ! What do you think about modifying _get to accept an eager parameter instead?

modified in 1feea90

[abrichr]

Almost there!

[abrichr]

Thanks @Animesh404 ! Can you please clarify the use of subqueryload vs joinedload? Why are they both used in different locations?

[Animesh404]

Thanks @Animesh404 ! Can you please clarify the use of subqueryload vs joinedload? Why are they both used in different locations?

both are used for eagerloading. subqueryload is used for indirect relationships whereas joinedload for direct ones.

[abrichr]

LGTM!