Add Recording Smoke Test#958
Closed
gokseniin wants to merge 1 commit into
Closed
Conversation
This file contains a smoke test for the OpenAdapt recording functionality, verifying the recorder's ability to start, capture data, stop via keyboard interrupt, and persist data.
Member
|
Closing as part of the architecture transition. The legacy codebase has been moved to If this change is still needed, please:
See PR #960 for details on the new meta-package architecture. |
Author
Member
|
@gokseniin thank you for your interest. For now the bounties are closed, but if you're interested in contributing we are open to suggestions. Please feel free to reach out on Discord. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I've added an automated smoke test for the recording functionality to address #775.
What kind of change does this PR introduce?
Implementation Details:
openadapt.recordin a background daemon thread to avoid blocking the main test execution.pynputto simulate theCtrl+Ckeyboard interrupt.KeyboardInterruptexception. This ensures that the test runner doesn't crash (especially on Windows) and can proceed to the verification step cleanly.Recordingentry was created.video_path). I added a check to handle cases where the schema version might differ, so the test remains stable across environments.ctypeshard exit strategy to preventmultiprocessingpermission errors causing hanging processes on Windows.Checklist
Fixes
Fixes #775
/claim #775
Demo Video
smoke_test_demo.mp4