fix: TelemetryCallback import crash + 12 TRL tests#231
Merged
Conversation
The dynamic __bases__ assignment to inject TrainerCallback as a base class fails in Python: "deallocator differs from object". Fixed by creating a proper subclass at definition time instead. 12 new tests: - Mock rollout_func: correct keys, count, reward variance - Config separation: TrainingConfig has no TRL fields, wrapper accepts trl_config - Wrapper construction: all callback combinations, trl_config passthrough - TelemetryCallback: importable, fires events Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bases crash. 12 tests for TRL integration.