feat: unify action format with openadapt-types#237
Closed
abrichr wants to merge 1 commit into
Closed
Conversation
…ntradiction - Fix the internal contradiction where SYSTEM_PROMPT described JSON format but ACTION_REGEX constrained to DSL format - Replace DSL-format SYSTEM_PROMPT with unified JSON format including reasoning field, aligning with openadapt-types Action schema - Add _AgentOutput Pydantic model for Outlines JSON schema mode - Update ACTION_REGEX to match JSON format (fallback for regex mode) - Update _build_outlines_generator to try JSON schema mode first, fall back to regex - Add DSL fallback parsing in parse_action_json for backward compatibility with existing checkpoints (CLICK/TYPE/WAIT/DONE format) - Add openadapt-types>=0.1.0 as core dependency - Fix mock adapter observe() for pre-rollout health check tests - Add 17 new tests covering DSL parsing, ACTION_REGEX, and _AgentOutput Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
|
Closing: this PR replaces the DSL system prompt with JSON, which re-introduces the garbage output bug fixed in #236. Cherry-picking the good parts (openadapt-types dep, _AgentOutput model, tests) into a new PR on top of current main. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix trl_rollout JSON/DSL contradiction, add openadapt-types dep, add _AgentOutput schema, 17 new tests