fix: remove bash syntax error in socat nohup fallback#63
Merged
Conversation
`&;` is a syntax error in bash — `&` already acts as a command terminator, so the trailing `;` causes a parse error. This broke the socat nohup fallback on VMs without the systemd service. Affects both run_dc_eval.py and record_waa_demos.py. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
&;is a bash syntax error —&already terminates the command, so the trailing;causes a parse errorsocat-waa-evaluatesystemd servicerun_dc_eval.pyandrecord_waa_demos.pyContext
The bug was introduced when the systemd-first pattern was added (PR #62 for
record_waa_demos.py, and earlier forrun_dc_eval.py). Theif/elseblock works fine on the systemd path; only the nohup fallback was broken.Test plan
🤖 Generated with Claude Code