fix: include image placeholder in chat template for VLM GRPO training#59
Merged
fix: include image placeholder in chat template for VLM GRPO training#59
Conversation
Qwen2.5-VL requires <|image_pad|> tokens in the input. These are
inserted by apply_chat_template only when messages include
{"type": "image"} content blocks.
Fixed both agent_fn and _compute_rollout_loss.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ValueError in Qwen2.5-VL GRPO. Both agent_fn and _compute_rollout_loss now include image content blocks in messages for apply_chat_template.