fix: use binary-mode subprocess for GitHub release asset downloads#6
Merged
fix: use binary-mode subprocess for GitHub release asset downloads#6
Conversation
The release asset scanner was failing to download all assets because: 1. _download_asset used _gh_api() which runs with text=True, corrupting binary asset content 2. _download_asset_binary first tried gh release download --pattern * without specifying a release tag (defaulted to latest instead of the target release) 3. The fallback used --output which is not a valid gh api flag 4. Even the fallback used run_cmd() with text=True Replace both methods with a single _download_asset_binary that calls gh api with Accept: application/octet-stream in binary mode (text=False) and writes raw bytes to disk. gh api handles auth and redirect-following automatically. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix release asset scanner: text=True corrupted binary data, gh release download had no tag, --output is not a valid gh api flag. Now uses subprocess.run with text=False and Accept: application/octet-stream.