[SECURITY] Replace Tink and Scrypt with native Android Keystore and A…#783
Merged
prathieshna merged 1 commit intoNEXT-WITHOUT-STORACHAfrom Apr 26, 2026
Merged
Conversation
…ES-256-GCM
- Refactor `TinkVaultCredentialStore` and `PasscodeRepository` to use native `AndroidKeyStore` and `Cipher` (AES/GCM/NoPadding) for encryption, removing the Google Tink dependency.
- Remove `ScryptHashingStrategy` and associated Bouncy Castle dependencies.
- Replace ML Kit barcode scanning with ZXing in `QRImageAnalyzer` to reduce binary size (~20MB saving).
- Update `app/proguard-rules.pro` with comprehensive rules for Room, Koin, Retrofit, Serialization, and native JNI bridges.
- Update `app/build.gradle.kts`:
- Enable ProGuard minification and resource shrinking for release builds.
- Restrict NDK ABIs to `arm64-v8a` and `armeabi-v7a`.
- Apply locale filters to strip unused resources.
- Remove several unused dependencies (Guava, Picasso, ML Kit, Bouncy Castle, etc.).
- Modify `IaConduit` to stop uploading C2PA manifests to Internet Archive and update `MediaPicker` to only generate C2PA manifests for in-app camera captures.
- Improve `FolderBar` UI with updated typography and error colors for destructive actions.
- Bump `versionCode` to 30031 and `versionName` to 4.0.10.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ES-256-GCM
TinkVaultCredentialStoreandPasscodeRepositoryto use nativeAndroidKeyStoreandCipher(AES/GCM/NoPadding) for encryption, removing the Google Tink dependency.ScryptHashingStrategyand associated Bouncy Castle dependencies.QRImageAnalyzerto reduce binary size (~20MB saving).app/proguard-rules.prowith comprehensive rules for Room, Koin, Retrofit, Serialization, and native JNI bridges.app/build.gradle.kts:arm64-v8aandarmeabi-v7a.IaConduitto stop uploading C2PA manifests to Internet Archive and updateMediaPickerto only generate C2PA manifests for in-app camera captures.FolderBarUI with updated typography and error colors for destructive actions.versionCodeto 30031 andversionNameto 4.0.10.