Replace direct-DB validator deregistration with consensus-based removal#143
Merged
raymondjacobson merged 6 commits intomainfrom Mar 13, 2026
Merged
Replace direct-DB validator deregistration with consensus-based removal#143raymondjacobson merged 6 commits intomainfrom
raymondjacobson merged 6 commits intomainfrom
Conversation
rickyrombo
approved these changes
Mar 12, 2026
Contributor
rickyrombo
left a comment
There was a problem hiding this comment.
Was the problem that deregistered state was not going through consensus or jailing?
Contributor
Author
deregistered state was not going through consensus, at all! there was a function to just watch eth events coming in and then straight up remove the node |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
deregisterValidator()function was directly deleting rows from core_validators outside of CometBFT consensus, causing state drift across nodes. Production nodes were reporting different chain state node counts because each node independently decided when to delete entries. Moreover depending on which node you state sync from, you may get different initial values in the validators table.In this PR:
ValidatorDeregistrationproto message to distinguish between jailing (underperformance) and removal (eth L1 deregistration, deletes row entirely)removeValidator()which submits a deregistration attestation with remove=true through CometBFT consensus, ensuring all nodes process the deletion deterministically