Skip to content

Add --end flag to ETL example runner#207

Merged
rickyrombo merged 2 commits intomainfrom
mjp-etl-end-flag
Apr 24, 2026
Merged

Add --end flag to ETL example runner#207
rickyrombo merged 2 commits intomainfrom
mjp-etl-end-flag

Conversation

@rickyrombo
Copy link
Copy Markdown
Contributor

Summary

  • Adds --end flag to examples/etl CLI so the indexer stops at a specific block height instead of running forever. Uses the existing SetEndingBlockHeight method on the Indexer.

Test plan

  • Verified locally: ETL stops cleanly at the specified end block

🤖 Generated with Claude Code

Enables running the ETL over a specific block range, useful for
verification against known-good snapshots.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rickyrombo rickyrombo requested a review from Copilot April 23, 2026 23:35
@rickyrombo
Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

# Conflicts:
#	examples/etl/main.go

Co-authored-by: rickyrombo <3690498+rickyrombo@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 23, 2026

@copilot resolve the merge conflicts in this pull request

Merged origin/main into this branch (fd69175). The conflict in examples/etl/main.go was resolved by keeping both the --end flag from this PR and the --skip-migrations flag added in #208.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an --end flag to the examples/etl CLI runner so the ETL indexer can stop at a specified block height (instead of running indefinitely), leveraging the existing Indexer.SetEndingBlockHeight capability.

Changes:

  • Add --end CLI flag with 0 = run forever behavior.
  • Wire the flag into the indexer configuration via SetEndingBlockHeight.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread examples/etl/main.go
@rickyrombo rickyrombo merged commit e900c58 into main Apr 24, 2026
12 of 14 checks passed
@rickyrombo rickyrombo deleted the mjp-etl-end-flag branch April 24, 2026 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants