Temporarily block artist-coin attestations at the node#215
Merged
dylanjeffers merged 4 commits intomainfrom May 1, 2026
Merged
Temporarily block artist-coin attestations at the node#215dylanjeffers merged 4 commits intomainfrom
dylanjeffers merged 4 commits intomainfrom
Conversation
Reject all calls to the Connect-side GetRewardAttestation handler, which serves DB-stored programmatic rewards (artist coins). The legacy HTTP /core/rewards/attestation handler remains unchanged so AUDIO challenge attestations continue to be issued. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add a TODO on GetRewardAttestation noting the rejection is a temporary measure to be reverted when artist-coin attestations are re-enabled, and reflect "temporarily" in the user-facing error so callers can tell it apart from a permanent removal. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dylanjeffers
changed the title
rickyrombo
approved these changes
May 1, 2026
Contributor
rickyrombo
left a comment
rickyrombo
left a comment
There was a problem hiding this comment.
I think maybe don't update the tests and just skip them for now? idk doesn't really matter
Restore the original two GetRewardAttestation subtests with t.Skip at the top so they're preserved for when the temporary block on GetRewardAttestation is reverted. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Bumps version so the artist-coin attestation block in this PR can ship as v1.2.12. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CoreService.GetRewardAttestation(Connect handler) now rejects every request withFailedPrecondition: artist-coin attestations are temporarily disabled. We intend to bring this flow back; aTODOis left on the handler pointing at git history for the previous implementation./core/rewards/attestationhandler that serves $AUDIO challenge attestations is untouched, so AUDIO claims continue to work.12_rewards_test.gowith a single subtest that asserts the rejection. The reward-lifecycle subtest is unchanged.Test plan
go build ./...(verified locally)go test -run NONE ./pkg/integration_tests/...(compiles)make test-integrationand confirmTestRewardsLifecycle/Artist-coin_attestations_are_rejectedpasses/core/rewards/attestationHTTP path)🤖 Generated with Claude Code