fix: use RichTooltip for help icons in Safari/Edge#557
Open
Br1an67 wants to merge 1 commit intoOpenBMB:mainfrom
Open
fix: use RichTooltip for help icons in Safari/Edge#557Br1an67 wants to merge 1 commit intoOpenBMB:mainfrom
Br1an67 wants to merge 1 commit intoOpenBMB:mainfrom
Conversation
Replace native HTML title attributes on help icons with the existing RichTooltip component for consistent cross-browser tooltip behavior. The native title attribute has inconsistent behavior across Safari and Edge, causing help tooltips to not appear when users interact with the question mark icons. Fixes OpenBMB#538
Collaborator
|
Thanks a lot for the PR 👍 However, after further investigation on our side, it seems the tooltip issue in Safari/Edge may stem from a more fundamental cause: some help text are actually empty. In such cases, even replacing the native So for now, we won’t be merging this PR. If we later confirm that a UI-level adjustment is still needed, we’ll follow up and move things forward accordingly. Thanks again for your contribution — we really appreciate it 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Help icon tooltips (the ? icons next to form field labels) do not appear in Safari and Edge on macOS, as reported in #538.
Root Cause
The help icons in
DynamicFormField.vueused native HTMLtitleattributes for tooltips. The nativetitleattribute has inconsistent behavior across browsers — particularly in Safari and Edge, where:Solution
Replaced all 11 native
title-based help icons with the existingRichTooltipcomponent, which already provides:Changes
frontend/src/components/DynamicFormField.vue: Wrapped all help icon<span>elements with<RichTooltip>and addedtabindex="0"for keyboard focus. Imported theRichTooltipcomponent.Testing
vite buildpasses successfullyvue/no-mutating-props) remain unchangedFixes #538