CDRW-4803 add dcsv enum to the ob internal codeset under external document format1 code#8
Merged
cjrobbertse-ob merged 12 commits intov4.0.1-draft-1from Nov 18, 2025
Conversation
…' into CDRW-4803-Add-DCSV-enum-to-the-OB_Internal_Codeset-under-ExternalDocumentFormat1Code
cjrobbertse-ob
changed the title
cjrobbertse-ob
changed the title
…dd-DCSV-enum-to-the-OB_Internal_Codeset-under-ExternalDocumentFormat1Code
OBPeteS
requested changes
Nov 12, 2025
Contributor
OBPeteS
left a comment
OBPeteS
left a comment
There was a problem hiding this comment.
Needs a description for DCSV
Contributor
Author
|
@OBPeteS Please let me know if you are happy with the name and description given for DCSV - I made them up, so don't actually know if correct. |
OBPeteS
requested changes
Nov 13, 2025
Contributor
OBPeteS
left a comment
OBPeteS
left a comment
There was a problem hiding this comment.
Description looks good, PR is missing the Excel file update?
…dd-DCSV-enum-to-the-OB_Internal_Codeset-under-ExternalDocumentFormat1Code
…dd-DCSV-enum-to-the-OB_Internal_Codeset-under-ExternalDocumentFormat1Code
OBPeteS
requested changes
Nov 17, 2025
Contributor
OBPeteS
left a comment
OBPeteS
left a comment
There was a problem hiding this comment.
Seeing as we removed the xlsx does this PR still need review or does it need processing on the csv instead?
…Internal_Codeset-under-ExternalDocumentFormat1Code
OBPeteS
approved these changes
Nov 17, 2025
…Internal_Codeset-under-ExternalDocumentFormat1Code
cjrobbertse-ob
deleted the
CDRW-4803-Add-DCSV-enum-to-the-OB_Internal_Codeset-under-ExternalDocumentFormat1Code
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.