Cache dom views #1629
Cache dom views #1629
Conversation
js/router.js
Outdated
| // time to come back to it in it's current state. | ||
| for (var key in this.viewCache) { | ||
| let cached = this.viewCache[key], | ||
| curHash = location.hash.slice(1); |
There was a problem hiding this comment.
What is curHash used for? I can't find it anywhere else in the code.
There was a problem hiding this comment.
No idea - I'm sure it had a use at some point, but I must have changed the code and forgot to clean it up. I've removed it.
|
When I merged this with master, the search bar on the discover stopped working right. When I typed in a search term and clicked enter, it didn't hide the Personalize/Random tab. Sometimes it would work, but the X button in the search bar wouldn't register clicks. This might be due to the merge, or do to something that changed since you started on this. Can you bring this up to date with the master branch and check es-lint for any issues? |
|
Did a merge and cleaned some stuff up. Search bar seems to be working correctly now. |
2 participants
closes #129
partially fixes #1570
Applies view caching, including restoring of the scroll position, to the Discover page & the Settings page. This is not applied to the Userpage, because that view needs some refactoring to support it first (will look to do that a little later and will make a separate PR).