This repository was archived by the owner on May 16, 2019. It is now read-only.
1622 #1654
Merged
1622 #1654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js/views/itemEditVw.js
Outdated
| this.$('#inputKeyword').removeClass('invalid'); | ||
| }, | ||
| onTagRemove: () => { | ||
| this.$('#inputKeyword').addClass('invalid'); |
Contributor
There was a problem hiding this comment.
This marks the field as invalid if you have 3 tags, and delete one, leaving 2 tags.
You could put in a count that checks to see if there are zero tags when the remove event fires.
Collaborator
Author
There was a problem hiding this comment.
good catch. will fix shortly.
Collaborator
Author
|
Issues from peer review have been fixed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1622