This repository was archived by the owner on Mar 28, 2023. It is now read-only.
Update Dependencies for 2.3.5 #1781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjeffryes
changed the title
…/openbazaar-desktop into updateDependencies235
…/openbazaar-desktop into updateDependencies235
jjeffryes
commented
Aug 5, 2019
| expect(cur.convertAndFormatCurrency(500, 'USD', 'PLN', { locale: 'en-US' })) | ||
| .to | ||
| .equal('PLN2,097.31'); | ||
| .satisfy(val => ['PLN2,097.31', 'PLN 2,097.31'].includes(val)); |
Contributor
Author
There was a problem hiding this comment.
This is a little ugly, but on my desktop it adds the space, and on Travis it doesn't, so this is the only way I've been able to get it to pass tests on both.
rmisio
reviewed
Aug 9, 2019
| "development": { | ||
| "presets": ["env", "stage-1"] | ||
| }, | ||
| "presets": [ |
Contributor
There was a problem hiding this comment.
At some point I think we could pare these down because I know we don't use a lot of these things (e.g. decorators). Just don't think we want to needlessly increase the file size of the bundled app or the amount of deps that have to come down the wire.
rmisio
approved these changes
Aug 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates a variety of dependencies for release 2.3.5 or later. This is primarily a precaution, so we don't end up too far behind on our libraries.
The major changes here are Babel and Electron.
Babel's syntax is different, I used https://github.com/babel/babel-upgrade to auto-generate the new dependencies.
Electron has been updated to v5.0.5, it now defaults to
nodeIntegration: false, which required it to be set to true when the browser window is created.Note: after updating Node to 10.16.0, I had to delete my node_modules file and reinstall everything with
npm installto get around a too many files open issue when browser sync started watching the sass files.Also, one of the currency tests started to fail, and required a small tweak to get it working right. The PLN currency test has a space between the PLN and the amount now.
Closes #1654
Closes #1771
Closes #1774