This repository was archived by the owner on Mar 28, 2023. It is now read-only.
Reset Type Filter on Suggestion Click #1796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will reset the type filter when a suggestion is clicked. Previously if you clicked the See All button for the Cryptocurrency category, it would set the filter to Cryptocurrency, and that filter would remain in place when you clicked a suggestion.
(filters not changing is intended, so if you have filtered to show only listings that accept ZEC, for instance, that remains true when you click a suggestion. But if you have filtered for a type, like digital goods, it's reasonable to reset that if you click a suggestion like clothing)
Closes #1782